-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable RUM response headers #3696
Comments
I see no harm in adding these headers to the server endpoint. But to be honest these are totally unnecessary headers for the server endpoint as we are not serving/loading arbitrary content from the server. |
Thanks for the input @vigneshshanmugam. Understood about the necessity of these headers, I'm happy to add them for cases where it makes adoption easier for our users that need a box checked requiring these headers. |
We should be careful adding these specific headers. Every customer security team has their own special headers, if we set these, a different customer will request something else. It would make sense to go the Kibana route where users can specify any arbitrary headers they want via a configuration setting (see server.customResponseHeaders) |
@joshbressers suggestion seems reasonable to me. Even though these headers will probably have no effect in most cases, supporting a config option would cover a lot of different use-cases without having to hardcode any specific header. |
We discussed an option like Kibana's I'll update the description to reflect that. Implementer should follow up on what validation is done for |
All intake responses currently include a
X-Content-Type-Options "nosniff"
header. Users would like some additional headers, often for compliance. Examples include:X-Frame-Options "SAMEORIGIN"
X-Xss-Protection "1; mode=block"
Content-Security-Policy "default-src https: data: 'unsafe-inline' 'unsafe-eval'"
for these endpoints:
@jahtalab @vigneshshanmugam any concerns about adding these for all RUM intake responses?
Following @joshbressers' suggestion, this issue is for a new configuration option
apm-server.rum.response_headers
as a dictionary, matching kibana's definition:as well as our own
output.elasticsearch.headers
config. While multiple headers with the same key are normal in responses, they are also permitted to be combined so there shouldn't be an issue with using a dictionary.This should not be alllowlist on cloud without confirming validation rules first.
The text was updated successfully, but these errors were encountered: