Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards incompatible changes to consider for 7.0 #1509

Closed
6 tasks
roncohen opened this issue Nov 2, 2018 · 8 comments
Closed
6 tasks

Backwards incompatible changes to consider for 7.0 #1509

roncohen opened this issue Nov 2, 2018 · 8 comments
Milestone

Comments

@roncohen
Copy link
Contributor

roncohen commented Nov 2, 2018

This is a list to track things we'd like to change which cannot be changed in a minor:

Documents in Elasticsearch:

Refactoring APM Server:

@alvarolobato alvarolobato added this to the 7.0 milestone Nov 13, 2018
@simitt
Copy link
Contributor

simitt commented Nov 23, 2018

related: planned breaking changes in beats

@simitt
Copy link
Contributor

simitt commented Nov 23, 2018

Refactoring APM Server:

To discuss:

@graphaelli
Copy link
Member

graphaelli commented Nov 29, 2018

To discuss: #1679

  • Change / response format. The ok doesn't match the new v2 response format so now it seems strange. For reference, es 7 looks like:
HTTP/1.1 200 OK
content-type: application/json; charset=UTF-8
content-length: 513

{
  "name" : "06b42f641b07",
  "cluster_name" : "docker-cluster",
  "cluster_uuid" : "u58I5cGVRgyJm1uRigWJjg",
  "version" : {
    "number" : "7.0.0-SNAPSHOT",
    "build_flavor" : "default",
    "build_type" : "tar",
    "build_hash" : "5eb7040",
    "build_date" : "2018-11-29T17:32:22.811477Z",
    "build_snapshot" : true,
    "lucene_version" : "8.0.0",
    "minimum_wire_compatibility_version" : "6.6.0",
    "minimum_index_compatibility_version" : "6.0.0-beta1"
  },
  "tagline" : "You Know, for Search"
}
```  changing this may impact the java agent.

@graphaelli
Copy link
Member

graphaelli commented Dec 4, 2018

Change apm-server.host to an array of hosts and allow listening on multiple interfaces

@graphaelli
Copy link
Member

graphaelli commented Dec 12, 2018

To discuss: #1681

Switch to user-friendly configuration. For example, replace:

output.elasticsearch.indices:
    - index: "apm-%{[beat.version]}-error-%{+yyyy.MM.dd}"
      when.contains:
        processor.event: "error"

with something like:

apm-server.elasticsearch.indices:
  - error: "apm-%{[beat.version]}-error-%{+yyyy.MM.dd}"

@jalvz
Copy link
Contributor

jalvz commented Dec 14, 2018

Switch to user-friendly configuration

Moreover, consider only allowing changes that don't break the UI (eg adding a string after apm) and not any arbitrary change such us removing {beat.version}.

@jalvz
Copy link
Contributor

jalvz commented Dec 14, 2018

Consider #1401

@simitt
Copy link
Contributor

simitt commented Dec 19, 2018

Closing this, as we created issues for every single suggestion that we will consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants