Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving span.hex_id to span.id #1677

Closed
simitt opened this issue Dec 19, 2018 · 3 comments
Closed

Moving span.hex_id to span.id #1677

simitt opened this issue Dec 19, 2018 · 3 comments
Labels
breaking change needs design
Milestone
7.0

Comments

@simitt
Copy link
Contributor

simitt commented Dec 19, 2018

span.hex_id is a keyword while span.id is a long.
Investigate if we can find a way to move hex_id to id without this being a breaking change.
@simitt simitt added this to the 7.0 milestone Dec 19, 2018
@roncohen roncohen mentioned this issue Dec 19, 2018
Closed
6 tasks
@jalvz
Copy link
Contributor

jalvz commented Jan 17, 2019

This can be done in the reindexing script

@simitt simitt mentioned this issue Jan 17, 2019
Closed
4 tasks
@simitt simitt changed the title Investigate moving span.hex_id to span.id Moving span.hex_id to span.id Jan 17, 2019
@jalvz
Copy link
Contributor

jalvz commented Jan 17, 2019

related: #1808

@graphaelli
Copy link
Member

closing this out as it has been moved in code and #1807 is tracking the reindex task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change needs design
Projects
None yet
Milestone
7.0
Development

No branches or pull requests
4 participants
@graphaelli @jalvz @simitt @alvarolobato