Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Change duration to be microseconds #2

Closed
12 of 14 tasks
watson opened this issue Oct 16, 2018 · 2 comments
Closed
12 of 14 tasks

Proposal: Change duration to be microseconds #2

watson opened this issue Oct 16, 2018 · 2 comments

Comments

@watson
Copy link
Contributor

watson commented Oct 16, 2018

Today the duration property is in milliseconds, but can represent microseconds using decimals:
1.234ms = 1234us

In the new intake API (v2), we change the timestamp properties to be an integer representing the number of microseconds since January 1, 1970 00:00:00 UTC.

I feel it would therefore be confusing to keep duration a milliseconds property.

@elastic/apm-server @elastic/apm-agent-devs Please vote on the following two questions:

Let's change duration to be in microseconds (at some point)

  • APM Server
  • RUM agent
  • Node.js agent
  • Python agent
  • Ruby agent
  • Java agent
  • Go agent

Our team have time to implement this change before API v2 (or it doesn't affect the team)

  • APM Server
  • RUM agent
  • Node.js agent
  • Python agent
  • Ruby agent
  • Java agent
  • Go agent
@mikker
Copy link
Contributor

mikker commented Oct 16, 2018

Very clear description of the issue and what voting means and entails 👏

@alvarolobato
Copy link
Contributor

We all agree that it would be good having this change in V2, but this is a last minute change and not all agents are going to have time to do it. Not having all the agents with this change in before FF is an additional risk on top of the ones we already have. We will defer to another release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants