Skip to content

Commit

Permalink
docs/spec: fix JSON Schema for arrays of objects (#4516)
Browse files Browse the repository at this point in the history 
The properties for array items should be tested under "items",
not added directly to the array object.
  • Loading branch information
@axw @simitt
axw authored and simitt committed Dec 15, 2020
1 parent c5bde23 commit c644867
Show file tree
Hide file tree
Showing 7 changed files with 1,029 additions and 1,001 deletions.
4 changes: 4 additions & 0 deletions NOTICE.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3994,6 +3994,7 @@ Contents of "LICENSE":

--------------------------------------------------------------------
Dependency: golang.org/x/sys
<<<<<<< HEAD
Revision: ef89a241ccb3
License type (autodetected): BSD-3-Clause
Contents of "LICENSE":
Expand Down Expand Up @@ -4029,6 +4030,9 @@ Contents of "LICENSE":
--------------------------------------------------------------------
Dependency: golang.org/x/term
Revision: f5c789dd3221
=======
Revision: 5cba982894dd
>>>>>>> 726b152d3... docs/spec: fix JSON Schema for arrays of objects (#4516)
License type (autodetected): BSD-3-Clause
Contents of "LICENSE":

Expand Down
315 changes: 159 additions & 156 deletions docs/spec/rumv3/error.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -363,10 +363,7 @@
"array"
],
"items": {
"type": [
"null",
"object"
]
"type": "object"
},
"minItems": 0
},
Expand Down Expand Up @@ -407,86 +404,89 @@
"null",
"array"
],
"properties": {
"ap": {
"description": "AbsPath is the absolute path of the frame's file.",
"type": [
"null",
"string"
]
},
"cli": {
"description": "ContextLine is the line from the frame's file.",
"type": [
"null",
"string"
]
},
"cn": {
"description": "Classname of the frame.",
"type": [
"null",
"string"
]
},
"co": {
"description": "ColumnNumber of the frame.",
"type": [
"null",
"integer"
]
},
"f": {
"description": "Filename is the relative name of the frame's file.",
"type": "string"
},
"fn": {
"description": "Function represented by the frame.",
"type": [
"null",
"string"
]
},
"li": {
"description": "LineNumber of the frame.",
"type": [
"null",
"integer"
]
},
"mo": {
"description": "Module to which the frame belongs to.",
"type": [
"null",
"string"
]
},
"poc": {
"description": "PostContext is a slice of code lines immediately before the line from the frame's file.",
"type": [
"null",
"array"
],
"items": {
"type": "string"
"items": {
"type": "object",
"properties": {
"ap": {
"description": "AbsPath is the absolute path of the frame's file.",
"type": [
"null",
"string"
]
},
"minItems": 0
},
"prc": {
"description": "PreContext is a slice of code lines immediately after the line from the frame's file.",
"type": [
"null",
"array"
],
"items": {
"cli": {
"description": "ContextLine is the line from the frame's file.",
"type": [
"null",
"string"
]
},
"cn": {
"description": "Classname of the frame.",
"type": [
"null",
"string"
]
},
"co": {
"description": "ColumnNumber of the frame.",
"type": [
"null",
"integer"
]
},
"f": {
"description": "Filename is the relative name of the frame's file.",
"type": "string"
},
"minItems": 0
}
"fn": {
"description": "Function represented by the frame.",
"type": [
"null",
"string"
]
},
"li": {
"description": "LineNumber of the frame.",
"type": [
"null",
"integer"
]
},
"mo": {
"description": "Module to which the frame belongs to.",
"type": [
"null",
"string"
]
},
"poc": {
"description": "PostContext is a slice of code lines immediately before the line from the frame's file.",
"type": [
"null",
"array"
],
"items": {
"type": "string"
},
"minItems": 0
},
"prc": {
"description": "PreContext is a slice of code lines immediately after the line from the frame's file.",
"type": [
"null",
"array"
],
"items": {
"type": "string"
},
"minItems": 0
}
},
"required": [
"f"
]
},
"required": [
"f"
],
"minItems": 0
},
"t": {
Expand Down Expand Up @@ -567,86 +567,89 @@
"null",
"array"
],
"properties": {
"ap": {
"description": "AbsPath is the absolute path of the frame's file.",
"type": [
"null",
"string"
]
},
"cli": {
"description": "ContextLine is the line from the frame's file.",
"type": [
"null",
"string"
]
},
"cn": {
"description": "Classname of the frame.",
"type": [
"null",
"string"
]
},
"co": {
"description": "ColumnNumber of the frame.",
"type": [
"null",
"integer"
]
},
"f": {
"description": "Filename is the relative name of the frame's file.",
"type": "string"
},
"fn": {
"description": "Function represented by the frame.",
"type": [
"null",
"string"
]
},
"li": {
"description": "LineNumber of the frame.",
"type": [
"null",
"integer"
]
},
"mo": {
"description": "Module to which the frame belongs to.",
"type": [
"null",
"string"
]
},
"poc": {
"description": "PostContext is a slice of code lines immediately before the line from the frame's file.",
"type": [
"null",
"array"
],
"items": {
"type": "string"
"items": {
"type": "object",
"properties": {
"ap": {
"description": "AbsPath is the absolute path of the frame's file.",
"type": [
"null",
"string"
]
},
"minItems": 0
},
"prc": {
"description": "PreContext is a slice of code lines immediately after the line from the frame's file.",
"type": [
"null",
"array"
],
"items": {
"cli": {
"description": "ContextLine is the line from the frame's file.",
"type": [
"null",
"string"
]
},
"cn": {
"description": "Classname of the frame.",
"type": [
"null",
"string"
]
},
"co": {
"description": "ColumnNumber of the frame.",
"type": [
"null",
"integer"
]
},
"f": {
"description": "Filename is the relative name of the frame's file.",
"type": "string"
},
"minItems": 0
}
"fn": {
"description": "Function represented by the frame.",
"type": [
"null",
"string"
]
},
"li": {
"description": "LineNumber of the frame.",
"type": [
"null",
"integer"
]
},
"mo": {
"description": "Module to which the frame belongs to.",
"type": [
"null",
"string"
]
},
"poc": {
"description": "PostContext is a slice of code lines immediately before the line from the frame's file.",
"type": [
"null",
"array"
],
"items": {
"type": "string"
},
"minItems": 0
},
"prc": {
"description": "PreContext is a slice of code lines immediately after the line from the frame's file.",
"type": [
"null",
"array"
],
"items": {
"type": "string"
},
"minItems": 0
}
},
"required": [
"f"
]
},
"required": [
"f"
],
"minItems": 0
}
},
Expand Down
Loading

0 comments on commit c644867

Please sign in to comment.