docs/spec: fix JSON Schema for arrays of objects #4516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The properties for array items should be tested under "items", not added directly to the array object.
simitt
approved these changes
Dec 10, 2020
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
|
It looks like some of the properties are missing a
Looking at the structs, these are |
|
@russcam that is expected. |
Gotcha! |
russcam
approved these changes
Dec 14, 2020
Codecov Report
@@ Coverage Diff @@
## master #4516 +/- ##
=======================================
Coverage 75.94% 75.95%
=======================================
Files 161 161
Lines 9783 9784 +1
=======================================
+ Hits 7430 7431 +1
Misses 2353 2353
|
|
Unrelated test failure -- #4366 |
simitt
pushed a commit
to simitt/apm-server
that referenced
this pull request
Dec 15, 2020
The properties for array items should be tested under "items", not added directly to the array object.
simitt
pushed a commit
to simitt/apm-server
that referenced
this pull request
Dec 15, 2020
The properties for array items should be tested under "items", not added directly to the array object.
simitt
added a commit
that referenced
this pull request
Dec 15, 2020
The properties for array items should be tested under "items", not added directly to the array object. Co-authored-by: Andrew Wilkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
The properties for array items should be tested under "items", not added directly to the array object.
Checklist
- [ ] I have updated CHANGELOG.asciidocI have considered changes for:
- [ ] documentation- [ ] logging (add log lines, choose appropriate log selector, etc.)- [ ] metrics and monitoring (create issue for Kibana team to add metrics to visualizations, e.g. Kibana#44001)- [ ] telemetry- [ ] Elasticsearch Service (https://cloud.elastic.co)- [ ] Elastic Cloud Enterprise (https://www.elastic.co/products/ece)- [ ] Elastic Cloud on Kubernetes (https://www.elastic.co/elastic-cloud-kubernetes)How to test these changes
???
Talk to @russcam
Related issues
Closes #4515