Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Racecar consumer instrumentation improvements #1429

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ErvalhouS
Copy link

What does this pull request do?

This PR adds better context to Racecar consumer transactions.

  1. Transaction naming now includes the consumer class, in a format that is similar to the current Rails instrumentation i.e.: ConsumerClass#method
  2. Transaction success/failure based on Racecar's exception handling

Why is it important?

Right now there's only the process.args to differ transactions happening in different consumers, which could be problematic since it isn't the default visualization grouping from other libraries. Error handling is also not recorded, what makes transactions be stored with an unknown status.

Checklist

  • I have signed the Contributor License Agreement.
  • My code follows the style guidelines of this project (See .rubocop.yml)
  • I have rebased my changes on top of the latest main branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • I have updated CHANGELOG.asciidoc
  • I have updated supported-technologies.asciidoc
  • Added an API method or config option? Document in which version this will be introduced

Related issues

Relates #1284

@picandocodigo
Copy link
Member

@elasticmachine run elasticsearch-ci/docs

@ErvalhouS
Copy link
Author

I don't think the tests failures had anything to do with the changes.

@picandocodigo
Copy link
Member

@ErvalhouS thank you for the contribution. No, the build failures are not related to your change. I'm trying to fix the build in a different PR and once that's done, I'll rebase this branch to bring in the changes. Thank you!

@picandocodigo picandocodigo force-pushed the feat-consumer-racecar-instrumentation branch from 07eadd5 to ca160ef Compare January 23, 2024 10:47
@ErvalhouS
Copy link
Author

@picandocodigo can we trigger a re-run on CI?

@picandocodigo picandocodigo force-pushed the feat-consumer-racecar-instrumentation branch from ca160ef to 6f2a0b1 Compare May 15, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants