Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Racecar instrumentation #1284

Merged
merged 9 commits into from
Sep 1, 2022
Merged

Racecar instrumentation #1284

merged 9 commits into from
Sep 1, 2022

Conversation

jaggederest
Copy link
Contributor

@jaggederest jaggederest commented Jun 23, 2022 •
edited
Loading

What does this pull request do?

Adds instrumentation for the Racecar library which consumes and produces Kafka messages

Why is it important?

Requested by a user in #1228

Checklist

  • I have signed the Contributor License Agreement.
  • My code follows the style guidelines of this project (See .rubocop.yml)
  • I have rebased my changes on top of the latest main branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Related issues

@jaggederest jaggederest linked an issue Jun 23, 2022 that may be closed by this pull request
Racecar instrumentation #1228
Closed
@apmmachine
Copy link
Contributor

apmmachine commented Jun 23, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-01T02:04:18.069+0000

  • Duration: 32 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 44687
Skipped 80
Total 44767

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Contributor

apmmachine commented Jun 23, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 99.225% (128/129) 👍 0.006
Classes 99.225% (128/129) 👍 0.006
Lines 68.117% (2959/4344) 👎 -0.397
Conditionals 100.0% (0/0) 💚

@jaggederest jaggederest mentioned this pull request Jul 22, 2022
Closed
@jaggederest
Copy link
Contributor Author

/test

2 similar comments
@jaggederest
Copy link
Contributor Author

/test

@jaggederest
Copy link
Contributor Author

/test

@jaggederest jaggederest marked this pull request as ready for review September 1, 2022 03:03
@jaggederest jaggederest merged commit b937dce into main Sep 1, 2022
@jaggederest jaggederest deleted the racecar-instrumentation branch September 1, 2022 03:09
@apmmachine
Copy link
Contributor

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-01T03:05:56.746+0000

  • Duration: 26 min 0 sec

Test stats 🧪

Test Results
Failed 1
Passed 42866
Skipped 76
Total 42943

Test errors 1

Expand to view the tests failures

Tests / Tests / Ruby:docker.elastic.co/observability-ci/jruby:9.2-8-jdk#rails-6.1 / ElasticAPM when running is expected to delegate :current_transaction to #<ElasticAPM::Agent:0x2acfd27b> – when running
    Expand to view the error details

     failed ElasticAPM when running is expected to delegate :current_transaction to #<ElasticAPM::Agent:0x2acfd27b>

    Expand to view the stacktrace

     
        undefined method `closed?' for nil:NilClass
["./lib/elastic_apm/transport/connection/http.rb:88:in `closed?'", "./lib/elastic_apm/transport/connection/http.rb:95:in `inspect'", "./lib/elastic_apm/agent.rb:277:in `inspect'", "./spec/support/delegate_matcher.rb:32:in `block in matches?'", "./spec/elastic_apm_spec.rb:227:in `block in <main>'", "/usr/local/bundle/jruby/2.5.0/gems/webmock-3.15.2/lib/webmock/rspec.rb:37:in `block in /usr/local/bundle/jruby/2.5.0/gems/webmock-3.15.2/lib/webmock/rspec.rb'"]

Steps errors 8

Expand to view the steps failures

Run BDD tests
  • Took 2 min 47 sec . View more details here
  • Description: ./spec/scripts/features.sh docker.elastic.co/observability-ci/jruby:9.2-11-jdk
Run BDD tests
  • Took 1 min 25 sec . View more details here
  • Description: ./spec/scripts/features.sh docker.elastic.co/observability-ci/jruby:9.2-11-jdk
Shell Script
  • Took 1 min 23 sec . View more details here
  • Description: ./spec/scripts/spec.sh docker.elastic.co/observability-ci/jruby:9.2-11-jdk sinatra-2.0
Shell Script
  • Took 1 min 24 sec . View more details here
  • Description: ./spec/scripts/spec.sh docker.elastic.co/observability-ci/jruby:9.2-11-jdk sinatra-2.0
Shell Script
  • Took 4 min 49 sec . View more details here
  • Description: ./spec/scripts/spec.sh docker.elastic.co/observability-ci/jruby:9.2-8-jdk rails-6.1
Shell Script
  • Took 4 min 47 sec . View more details here
  • Description: ./spec/scripts/spec.sh docker.elastic.co/observability-ci/jruby:9.2-8-jdk rails-6.1
Restore files previously stashed
  • Took 0 min 0 sec . View more details here
  • Description: jruby-9.2-11-jdk-rails-5.2
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: Ruby:docker.elastic.co/observability-ci/jruby:9.2-11-jdk#rails-5.2 tests failed : hudson.AbortException: script returned exit code 5

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

estolfo pushed a commit that referenced this pull request Mar 2, 2023
@jaggederest @estolfo
Racecar instrumentation (#1284)
30d7999 
* WIP racecar instrumentation

* Change to subscriber for racecar instrumentation

* Update to use transactions rather than spans

* Racecar WIP

* Updated Racecar instrumentation and specs

* Ignore racecar spec if ActiveSupport is not available

* Remove extra requires from spec_helper

* Add additional require to Racecar spy

* Update changelog for #1284
@ErvalhouS ErvalhouS mentioned this pull request Jan 8, 2024
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
agent-ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Racecar instrumentation
2 participants
@jaggederest @apmmachine