Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: workaround spurious test failures in http2 tests with node v8 #3226

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

trentm
Copy link
Member

@trentm trentm commented Mar 29, 2023

Closes: #2409


The http2 tests have been occasionally crashy in CI for a long time.. and more so in GH Actions of late. Let's just skip these tests. The need to run them is very low.

@trentm trentm self-assigned this Mar 29, 2023
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Mar 29, 2023
@trentm trentm merged commit a21c58e into main Mar 29, 2023
@trentm trentm deleted the trentm/skip-http2-tests-node-8 branch March 29, 2023 20:56
@apmmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-03-29T20:35:07.089+0000

  • Duration: 34 min 18 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

v1v added a commit that referenced this pull request Mar 30, 2023
* upstream/main:
  test: bump threshold to avoid spurious failure for possibly slow CI (#3225)
  test: workaround spurious test failures in http2 tests with node v8 (#3226)
peter-ein pushed a commit to fpm-git/apm-agent-nodejs that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spurious http2.createSecureServer stream respond test crash/error in GH Actions with node 8
2 participants