Skip to content

Commit

Permalink
Merge remote-tracking branch 'upstream/main' into feature/run-on-windows
Browse files Browse the repository at this point in the history
* upstream/main:
  test: bump threshold to avoid spurious failure for possibly slow CI (#3225)
  test: workaround spurious test failures in http2 tests with node v8 (#3226)
  • Loading branch information
v1v committed Mar 30, 2023
2 parents 3dc6169 + 4a0f096 commit 1c72b90
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion test/context-propagation-only.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ tape.test('contextPropagationOnly', function (suite) {
// stacktrace collection when contextPropagationOnly=true. It isn't a
// perfect way to test that.
const durationMs = duration[0] / 1e3 + duration[1] / 1e6
const THRESHOLD_MS = 5 // Is this long enough for slow CI?
const THRESHOLD_MS = 10 // Is this long enough for slow CI?
t.ok(durationMs < THRESHOLD_MS, `captureError is fast (<${THRESHOLD_MS}ms): ${durationMs}ms`)

t.equal(server.events.length, 0, 'no events sent to APM server intake')
Expand Down
5 changes: 5 additions & 0 deletions test/instrumentation/modules/http2.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ var mockClient = require('../../_mock_http_client')
var findObjInArray = require('../../_utils').findObjInArray
const constants = require('../../../lib/constants')

if (semver.satisfies(process.version, '8.x')) {
console.log('# SKIP http2 testing on node v8.x is crashy in CI')
process.exit()
}

var isSecure = [false, true]
isSecure.forEach(secure => {
var method = secure ? 'createSecureServer' : 'createServer'
Expand Down

0 comments on commit 1c72b90

Please sign in to comment.