module/apmgrpc: add stream interceptors #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
axw
force-pushed
the
apmgrpc-stream-interceptor
branch
from
62dd126 to
6be2edb
Compare
Codecov Report
@@ Coverage Diff @@
## master #918 +/- ##
==========================================
- Coverage 83.79% 83.61% -0.19%
==========================================
Files 140 141 +1
Lines 7895 8036 +141
==========================================
+ Hits 6616 6719 +103
- Misses 877 911 +34
- Partials 402 406 +4
Continue to review full report at Codecov.
|
stuartnelson3
approved these changes
Mar 24, 2021
| defer tx.End() | ||
|
|
||
| // TODO(axw) define context schema for RPC, | ||
| // including at least the peer address. |
There was a problem hiding this comment.
is context span.Context here?
stuartnelson3
pushed a commit
that referenced
this pull request
Jul 30, 2021
* module/apmgrpc: add stream interceptors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add server and client stream interceptors. Very similar to unary interceptors -- the transaction and span represents the entire gRPC stream.
Client spans are ended when the stream is closed, which is observed when stream methods return with an error, or for unary servers, RecvMsg returns (not necessarily with an error). This is very similar to the client wrapper in apmhttp, where the span is ended only after the response body is consumed.
Closes #901