-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gRPC Stream Interceptors #901
Comments
What would you expect the stream interceptors to measure? Beginning to end of stream? Anything in between? |
Something like how the Unary interceptors work.
The Logrus interceptor is a good basic example of how to retrieve the data. |
Yeah, the only thing I worry about is the max number of spans. It might be hit quicker for Stream APIs. |
@jpopadak if you have a chance to test this out some time soon I'd appreciate any feedback you may have, so we can make changes before the next release as needed. |
Is your feature request related to a problem? Please describe.
There currently exists within
apmgrpc
UnaryClientInterceptor
andUnaryServerInterceptor
.I see within the documentation it says no Stream support exists for gRPC.
Well, here I am asking for a Client and Server Stream Interceptor for gRPC use. 🙃
We have many services that use gRPC Stream APIs, and this is sadly one of our blockers for a quick migration.
Describe the solution you'd like
A similar interceptor (just as easy) as the
UnaryClientInterceptor
andUnaryServerInterceptor
.Describe alternatives you've considered
Additional context
Unrelated, but gRPC specific: Would be wonderful if we could also get #900 included.
The text was updated successfully, but these errors were encountered: