Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for storing HTTP Headers (Req & Resp) for gRPC calls #900

Closed
jpopadak opened this issue Feb 17, 2021 · 1 comment · Fixed by #904
Closed

Add Support for storing HTTP Headers (Req & Resp) for gRPC calls #900

jpopadak opened this issue Feb 17, 2021 · 1 comment · Fixed by #904
Labels
agent-go enhancement New feature or request

Comments

@jpopadak
Copy link

jpopadak commented Feb 17, 2021

Is your feature request related to a problem? Please describe.
There does not seem to be any documentation on how view headers from a gRPC request.

For example, the Host gets set for apmhttp (See #280) but not for apmgrpc. Why not, when grpc is over an HTTP2 connection?

Describe the solution you'd like
I would love if it could store the same request headers and the same response headers as apmhttp modules does. Thus, its easy to see standard headers from the apmgrpc interceptors. Ideality, it should happen in getIncomingMetadataTraceContext since it already pulls the Request Metadata.

Describe alternatives you've considered
Alternatives include creating our own interceptor that runs after the apmgrpc interceptor. It adds the headers to the parent span.

Additional context

@axw
Copy link
Member

axw commented Feb 17, 2021

Thanks for opening this @jpopadak. I agree, it would be very sensible to include the underlying HTTP-related context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-go enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants