Mark some more spans as exit spans #1334
Conversation
Also, note a bug in Span.End() when ending a child of an exit span.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
|
/test |
span.go
Outdated
| @@ -370,6 +370,9 @@ func (s *Span) End() { | |||
| s.Context.model.Destination = nil | |||
| s.Context.model.Service = nil | |||
|
|
|||
| // BUG(axw) s.parent.SpanData must be accessed with s.parent.mu held. | |||
| // Even then, s.parent.SpanData will be nil if ended, so we need to | |||
| // find an alternative approach. | |||
There was a problem hiding this comment.
Would you mind creating a gh issue for that bug? As I understand this won't be fixed within the same PR.
There was a problem hiding this comment.
I was intending to fix it in this PR. The other changes could slip to another release, but not this; this causes a panic if you end the parent before the child.
|
I haven't updated CHANGELOG, as the bug hasn't made it into a release. |
🌐 Coverage report
|
|
/test |
Also, note a bug in Span.End() when ending a child of an exit span.
Relates to #1315