Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spans representing calls to external services are not being marked as exit spans #1315

Closed
axw opened this issue Sep 19, 2022 · 0 comments · Fixed by #1317
Closed

Spans representing calls to external services are not being marked as exit spans #1315

axw opened this issue Sep 19, 2022 · 0 comments · Fixed by #1317
Assignees
Labels
agent-go bug Something isn't working v8.5.0
Milestone

Comments

@axw
Copy link
Member

axw commented Sep 19, 2022

Describe the bug

https://github.com/elastic/apm/blob/main/specs/agents/tracing-spans.md#exit-spans says

Exit spans are spans that describe a call to an external service, such as an outgoing HTTP request or a call to a database.

We are only setting ExitSpan: true in module/apmredigov8. We should update all other modules that create these kinds of spans.

Note that the spec also says:

A span is considered an exit span if it has explicitly been marked as such; a span's status should not be inferred.

This does not apply to spans created by built-in instrumentation; it applies to custom spans created through the API.

Expected behavior

We should be marking spans representing calls to external services as exit spans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-go bug Something isn't working v8.5.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants