-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Elastic.Clients.Elasticsearch
#1935
Merged
gregkalapos
merged 16 commits into
elastic:main
from
gregkalapos:Clients_ElasticSearch_Integration
Dec 7, 2022
Merged
Support for Elastic.Clients.Elasticsearch
#1935
gregkalapos
merged 16 commits into
elastic:main
from
gregkalapos:Clients_ElasticSearch_Integration
Dec 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking at
Update: fixed. |
z1c0
reviewed
Dec 6, 2022
test/Elastic.Clients.Elasticsearch.Tests/ElasticSearchTestFixture.cs
Outdated
Show resolved
Hide resolved
test/Elastic.Clients.Elasticsearch.Tests/ElasticSearchTestFixture.cs
Outdated
Show resolved
Hide resolved
test/Elastic.Clients.Elasticsearch.Tests/ElasticSearchTestFixture.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Wolfgang Ziegler <[email protected]>
`SuppressSpanCreation` -> `ShouldSuppressSpanCreation`
Rider "renaming" feature left me down.
z1c0
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is covering the rest of the things needed to support the new Elasticsearch .NET Client.
The core of the change was done directly in the client code: elastic/elasticsearch-net#6990
This PR adds:
elasticsearch
spans are already created by the OTel bridge.Regarding release: I think this should not block a release - if this ends up being merged after the next release, it's still fine.