Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Testcontainers v2.2.0 in Elastic.Apm.Elasticsearch.Tests #1936

Closed
gregkalapos opened this issue Dec 5, 2022 · 1 comment · Fixed by #1953
Closed

Use Testcontainers v2.2.0 in Elastic.Apm.Elasticsearch.Tests #1936

gregkalapos opened this issue Dec 5, 2022 · 1 comment · Fixed by #1953
Labels
agent-dotnet developer only Items that of interest only to developers working on the project good first issue Good for newcomers

Comments

@gregkalapos
Copy link
Contributor

Currently Elastic.Apm.Elasticsearch.Tests uses Testcontainers v2.1.0 which has no built-in ElasticsearchTestcontainer so we build the container in our code.

Testcontainers v2.2.0 added ElasticsearchTestcontainer so most of the building of the Elasticsearch container can be removed and we can just use ElasticsearchTestcontainer. This is already done in Elastic.Clients.Elasticsearch.Tests.csproj for the new client which was introduced in #1935.
@gregkalapos gregkalapos added good first issue Good for newcomers developer only Items that of interest only to developers working on the project labels Dec 5, 2022
@HofmeisterAn HofmeisterAn mentioned this issue Dec 16, 2022
Merged
@z1c0 z1c0 linked a pull request Jan 16, 2023 that will close this issue
chore: Update Testcontainers for .NET to version 2.3.0 #1953
Merged
@z1c0
Copy link
Contributor

z1c0 commented Jan 16, 2023

This was implemented in #1953.

@z1c0 z1c0 closed this as completed Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent-dotnet developer only Items that of interest only to developers working on the project good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Update Testcontainers for .NET to version 2.3.0
2 participants
@gregkalapos @z1c0