Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible doesn't verify docker as running #164

Merged
merged 4 commits into from
Sep 21, 2022
Merged

Ansible doesn't verify docker as running #164

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
869f9b9
Update configure_docker.yml
Verticaleap Sep 9, 2022
7dc5c9e
Update configure_docker.yml
Verticaleap Sep 9, 2022
a735c26
Update main.yml
Verticaleap Sep 20, 2022
244b992
Update configure_docker.yml
Verticaleap Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tasks/base/general/configure_docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,8 @@
name: docker
enabled: yes
daemon_reload: yes

- name: Start the docker service
Copy link
Contributor

@obierlaire obierlaire Sep 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for contributing!

I thinks this won't have the desired effect as we are rebooting the instance right after:

ansible-elastic-cloud-enterprise/tasks/direct-install/main.yml

Line 5 in 0624ea5

- name: Reboot the machine with all defaults

Having docker daemon enabled should be enough. However, if docker takes too long to start or fails to start (conf problem for example) it might be interesting to ensure that docker is up right before running the actual ECE install.

Moving this current piece of code right before this line might be what we need:

ansible-elastic-cloud-enterprise/tasks/ece-bootstrap/main.yml

Line 21 in 0624ea5

- name: Check if an installation or upgrade should be performed

Also, if anyone want to use this playbook to only bootstrap ECE (tag bootstrap), i.e. on a machine which was already provisioned (docker installed, configured) , that also might be interesting to ensure docker is up before starting the actual install of ECE.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your suggestion for the alternative location for the docker start task, I'll go ahead and test that change in my environment, just to make sure it functions as intended!

systemd:
name: docker
state: started