-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ansible doesn't verify docker as running #164
Conversation
💚 CLA has been signed |
@@ -52,3 +52,8 @@ | |||
name: docker | |||
enabled: yes | |||
daemon_reload: yes | |||
|
|||
- name: Start the docker service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for contributing!
I thinks this won't have the desired effect as we are rebooting the instance right after:
- name: Reboot the machine with all defaults |
Having docker daemon enabled should be enough. However, if docker takes too long to start or fails to start (conf problem for example) it might be interesting to ensure that docker is up right before running the actual ECE install.
Moving this current piece of code right before this line might be what we need:
- name: Check if an installation or upgrade should be performed |
Also, if anyone want to use this playbook to only bootstrap ECE (tag bootstrap
), i.e. on a machine which was already provisioned (docker installed, configured) , that also might be interesting to ensure docker is up before starting the actual install of ECE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like your suggestion for the alternative location for the docker start task, I'll go ahead and test that change in my environment, just to make sure it functions as intended!
We need to start docker back up prior to checking
docker ps
here:ansible-elastic-cloud-enterprise/tasks/ece-bootstrap/main.yml
Line 30 in 09bf023
This issue references the bug this PR should help resolve:
#109