Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ansible doesn't verify docker as running #164

Merged
merged 4 commits into from
Sep 21, 2022
Merged

Conversation

Verticaleap
Copy link
Contributor

We need to start docker back up prior to checking docker ps here:

shell: docker ps -a -f name=frc-runners-runner --format {%raw%}"{{.Image}}"{%endraw%}

This issue references the bug this PR should help resolve:
#109

@cla-checker-service
Copy link

cla-checker-service bot commented Sep 9, 2022

💚 CLA has been signed

@@ -52,3 +52,8 @@
name: docker
enabled: yes
daemon_reload: yes

- name: Start the docker service
Copy link
Contributor

@obierlaire obierlaire Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for contributing!

I thinks this won't have the desired effect as we are rebooting the instance right after:

- name: Reboot the machine with all defaults

Having docker daemon enabled should be enough. However, if docker takes too long to start or fails to start (conf problem for example) it might be interesting to ensure that docker is up right before running the actual ECE install.

Moving this current piece of code right before this line might be what we need:

- name: Check if an installation or upgrade should be performed

Also, if anyone want to use this playbook to only bootstrap ECE (tag bootstrap), i.e. on a machine which was already provisioned (docker installed, configured) , that also might be interesting to ensure docker is up before starting the actual install of ECE.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your suggestion for the alternative location for the docker start task, I'll go ahead and test that change in my environment, just to make sure it functions as intended!

@alpar-t alpar-t merged commit f31f507 into elastic:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants