Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Danger Xcode-Summary issue #11

Closed
wants to merge 3 commits into from
Closed

Danger Xcode-Summary issue #11

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1cd06e
Add some modification that should generate warning outputs in danger
Jan 18, 2020
519b74a
Fiix lint error only and keep the build warning
el-hoshino Jul 8, 2020
e69b766
Add another dummy variable for test
el-hoshino Jul 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions QuickshaRe/Domain/QRPictureGenerator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,12 @@ final public class QRPictureGenerator {

let context = CIContext()

private let dummy :Int = 123
Copy link
Owner Author

@el-hoshino el-hoshino Jan 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Colons should be next to the identifier when specifying a type and next to the key in dictionary literals.
colon QRPictureGenerator.swift:16

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colons should be next to the identifier when specifying a type and next to the key in dictionary literals.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colon at column 23 should have exactly one space after it

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colon at column 23 should have no spaces before it


public func qrPicture(for text: String) -> Picture {

let dummy = 123

let ciGenerator = CIFilter.qrCodeGenerator()
let qrCode = ciGenerator.qrCodeImage(for: text, correctionLevel: "H")!
let output = context.createCGImage(qrCode, from: qrCode.extent)!
Expand Down