Danger Xcode-Summary issue #11
Closed
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
el-hoshino
commented
Jan 19, 2020
| @@ -13,8 +13,12 @@ final public class QRPictureGenerator { | |||
|
|
|||
| let context = CIContext() | |||
|
|
|||
| private let dummy :Int = 123 | |||
There was a problem hiding this comment.
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals.colon QRPictureGenerator.swift:16 |
Code coverageTotal coverage:
|
| File | Coverage |
|---|---|
| QuickshaRe/Domain/QRPictureGenerator.swift | 100.00% |
Powered by Slather
Develop PR Check
| Checklist | Result |
|---|---|
| Check PR From branch | ⭕ |
| Check PR To branch | ⭕ |
| CHANGELOG.md Modification Check | ❗ |
| Merge Commit Check | ⭕ |
| Volume of Modification Check | ⭕ |
Generated by 🚫 Danger
el-hoshino
force-pushed
the
issue/XcodeSummaryIssue
branch
from
51d5b33
to
f1cd06e
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -13,8 +13,12 @@ final public class QRPictureGenerator { | |||
|
|
|||
| let context = CIContext() | |||
|
|
|||
| private let dummy :Int = 123 | |||
There was a problem hiding this comment.
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals.
| @@ -13,8 +13,12 @@ final public class QRPictureGenerator { | |||
|
|
|||
| let context = CIContext() | |||
|
|
|||
| private let dummy :Int = 123 | |||
There was a problem hiding this comment.
Colon at column 23 should have exactly one space after it
| @@ -13,8 +13,12 @@ final public class QRPictureGenerator { | |||
|
|
|||
| let context = CIContext() | |||
|
|
|||
| private let dummy :Int = 123 | |||
There was a problem hiding this comment.
Colon at column 23 should have no spaces before it
|
Code Climate has analyzed commit e69b766 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
danger-xcode_summary plugin's inline mode is not... quite inline. It can give us the info at which line in which file the warning/error comes from, but it can't leave a comment right on that line, which danger-swiftlint plugin is able to do in its inline mode.