-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Biobanks metadata with MIABIS structure #39
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some initial feedback for a discussion.
Valid points
- The
dcat:Resource
in the EJP RD model is missing thedct:indentifier
property that is very clearly part of DCAT2 and even if it was not part of DCAT2 it should have been added to realize the Findable aspect of data and metadata. This seems to be an oversight of the EJP RD model. - Basing biobank related concepts on OBIB is a sound idea that we may want to encourage.
- The EJP RD model does not include
dcat:contactPoint
ondcat:Resource
. Why? This would seem to make sense as both DCAT2 and FDP have it.
To discuss
-
The intent of the EJP RD meta-model is to only deal with meta-data. It therefore would seem that collections should not form part of meta-data as these in fact represent record data of biobanks. It would be similar to adding patient and diagnosis information for patient registries to the meta-data model. The fact that a collection seem to be a record-level element seems to be supported by the definition of OBIB_0000645 "A object aggregate that consists of specimens, participates in a study and is part of a biobank." Here is diagram representing collection data:
-
Should the EJPRD model include
fdp-o:metadataIdentifier
information? This seems very specific to FDP and not general the EJPRD meta-data model. Also, it seems thatfdp-o:metadataIdentifier
is deprecated based on [https://w3id.org/fdp/fdp-o#](See https://w3id.org/fdp/fdp-o#). However, when looking at https://specs.fairdatapoint.org/
it seems to still in use.
Possible error?
dct:isPartOf :catalog
but:catalog
is not defined.
I changed the mapping of the concepts of biobanks and collections. Now the MIABIS Collection is mapped to This mapping should also clarify the doubt about collections being records of the biobank: the collection metadata describes the samples while the MIABIS biobank contains only organizational data. For example, the metadata about the diseases treated is registered in the collection, from a MIABIS point of view. Other minor changes: I removed the FDP specific attributes from the examples and the |
…e biobankShape to be a foaf:Organization and introdue the legal entity for biobank
3eda2b2
to
e84820d
Compare
…th both MIABIS and previous EJP model
I changed again the mapping. Now it is really similar to the EJP previous model.
|
data/example-rdf/turtle/biobank.ttl
Outdated
dct:title "Biobank of Rare Diseases"; | ||
dct:alternative "BRD"; | ||
dct:description "Biobank with collections of biopsies of muscular diseases"; | ||
dcat:landingPage <https://brd.org>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be foaf:homepage
data/example-rdf/turtle/biobank.ttl
Outdated
a obo:OBIB_0000623, foaf:Organization; | ||
dct:identifier "biobank-id"; | ||
dct:title "Biobank of Rare Diseases"; | ||
dct:alternative "BRD"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not in the current model
data/example-rdf/turtle/biobank.ttl
Outdated
dct:identifier "collection-id"; | ||
dct:title "Muscle Tissue Collection"; | ||
dct:description "Example collection of samples"; | ||
dct:alternative "MTC"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not in the current model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, there is a typo here:
dcat:Resouce;
should be dcat:Resource;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed it in the new commit
data/example-rdf/turtle/biobank.ttl
Outdated
dct:identifier "collection-id"; | ||
dct:title "Muscle Tissue Collection"; | ||
dct:description "Example collection of samples"; | ||
dct:alternative "MTC"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, there is a typo here:
dcat:Resouce;
should be dcat:Resource;
This PR changes the metadata schema for biobanks in order to be compliant with the MIABIS schema
NB: currently it is missing the PNG with the representation of the schema