test: add test for #67

eiiches · Nov 23, 2020 · 2a4ab7b · 2a4ab7b
1 parent f93d865
commit 2a4ab7b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -130,7 +130,7 @@ This table illustrates which features (picked from jq-1.5 manual) are supported
 | &nbsp;&nbsp;&nbsp;&nbsp;&bull; [`unique`, `unique_by(path_exp)`](https://stedolan.github.io/jq/manual/v1.5/#unique&#44;unique&#95;by&#40;path&#95;exp&#41;)                                                                                                                                                                        | ○          |
 | &nbsp;&nbsp;&nbsp;&nbsp;&bull; [`reverse`](https://stedolan.github.io/jq/manual/v1.5/#reverse)                                                                                                                                                                                                                                     | ○          |
 | &nbsp;&nbsp;&nbsp;&nbsp;&bull; [`contains(element)`](https://stedolan.github.io/jq/manual/v1.5/#contains&#40;element&#41;)                                                                                                                                                                                                         | ○          |
-| &nbsp;&nbsp;&nbsp;&nbsp;&bull; [`indices(s)`](https://stedolan.github.io/jq/manual/v1.5/#indices&#40;s&#41;)                                                                                                                                                                                                                       | ○          |
+| &nbsp;&nbsp;&nbsp;&nbsp;&bull; [`indices(s)`](https://stedolan.github.io/jq/manual/v1.5/#indices&#40;s&#41;)                                                                                                                                                                                                                       | ○<sup>*9</sup> |
 | &nbsp;&nbsp;&nbsp;&nbsp;&bull; [`index(s)`, `rindex(s)`](https://stedolan.github.io/jq/manual/v1.5/#index&#40;s&#41;&#44;rindex&#40;s&#41;)                                                                                                                                                                                        | ○          |
 | &nbsp;&nbsp;&nbsp;&nbsp;&bull; [`inside`](https://stedolan.github.io/jq/manual/v1.5/#inside)                                                                                                                                                                                                                                       | ○          |
 | &nbsp;&nbsp;&nbsp;&nbsp;&bull; [`startswith(str)`](https://stedolan.github.io/jq/manual/v1.5/#startswith&#40;str&#41;)                                                                                                                                                                                                             | ○          |
@@ -224,6 +224,8 @@ This table illustrates which features (picked from jq-1.5 manual) are supported
 
 *8) `.foo |= empty` always throws an error in jackson-jq instead of producing an unexpected result. jq-1.5 and jq-1.6 respectively produces a different and incorrect result for `[1,2,3] | ((.[] | select(. > 1)) |= empty)`. [jq#897](https://github.com/stedolan/jq/issues/897) says "empty in the RHS is undefined". You can still use `_modify/2` directly if you really want to emulate the exact jq-1.5 or jq-1.6 behavior.
 
+*9) `"x" | indices("")` always returns an empty array in jackson-jq. The behavior is in line with jq after [2660b04](https://github.com/stedolan/jq/commit/2660b04a731568c54eb4b91fe811d81cbbf3470b) commit, but differs from how jq-1.5 and jq-1.6 behave.
+
 Using jackson-jq-extra module
 -----------------------------
 

diff --git a/jackson-jq/src/test/java/net/thisptr/jackson/jq/JsonQueryTest.java b/jackson-jq/src/test/java/net/thisptr/jackson/jq/JsonQueryTest.java
@@ -63,6 +63,9 @@ public static class TestCase {
 		@JsonProperty("should_compile")
 		public boolean shouldCompile = true;
 
+		@JsonProperty("ignore_true_jq_behavior")
+		public boolean ignoreTrueJqBehavior = false;
+
 		@JsonInclude(Include.NON_NULL)
 		@JsonProperty("v")
 		@JsonDeserialize(using = VersionRangeDeserializer.class)
@@ -156,7 +159,7 @@ private void test(final TestCase tc, final Version version) throws Throwable {
 			return;
 		}
 
-		if (hasJqCache.computeIfAbsent(version, v -> TrueJqEvaluator.hasJq(v))) {
+		if (!tc.ignoreTrueJqBehavior && hasJqCache.computeIfAbsent(version, v -> TrueJqEvaluator.hasJq(v))) {
 			final Result result = cachedJqEvaluator.evaluate(tc.q, tc.in, version, 2000L);
 			assumeThat(result.error).as("%s", command).isNull();
 			assumeThat(wrap(tc.out)).as("%s", command).isEqualTo(wrap(result.values));

diff --git a/jackson-jq/src/test/resources/tests/functions/indices.yaml b/jackson-jq/src/test/resources/tests/functions/indices.yaml
@@ -1 +1,2 @@
 - {"v":"[1.5,1.5]","q":"indices(-1.0)","in":null,"out":[null]}
+- {"v":"[1.5,1.6]","q":"indices(\"\")","in":"x","out":[[]],"ignore_true_jq_behavior":true}