indices/1: fix infinite loop on empty needle text (fix #59) #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@itchyny Thank you for reporting a number of subtle issues (which I wouldn't be able to find myself) and fixing this one. After merging this PR, I'll add a test case for this and publish a new release shortly. |
|
Yeah, since this is the only issue which can cause a server to hang, releasing would be nice. |
eiiches
added a commit
that referenced
this pull request
Nov 23, 2020
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #59. The
needlearray checks non-empty butneedleTextdidn't.