-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(doc): cookies 增加 partitioned、removeUnpartitioned 和 priority 选项文档 #5376
Conversation
WalkthroughThe documentation for cookie and session management in the Chinese language version has been updated to provide more comprehensive information about cookie settings and session handling. The changes focus on introducing new cookie options like Changes
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
site/docs/core/cookie-and-session.zh-CN.md (1)
31-31
: Documentation looks good, with minor enhancement suggestionsThe documentation for the new cookie options is well-structured and accurate. Consider these enhancements:
- Add quotes around the priority values for better clarity:
-可选值为 Low、Medium、High +可选值为 'Low'、'Medium'、'High'
- Consider adding a code example demonstrating the usage of these new options, similar to the existing examples for
httpOnly
andencrypt
.Also applies to: 34-34, 37-41
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
site/docs/core/cookie-and-session.zh-CN.md
(1 hunks)
🔇 Additional comments (1)
site/docs/core/cookie-and-session.zh-CN.md (1)
Line range hint 1-300
: Documentation formatting and structure is excellent
The document maintains consistent formatting and clear structure throughout. Technical terms are well-explained and properly linked to external resources. Browser compatibility information is clearly stated where relevant.
🧰 Tools
🪛 Markdownlint (0.37.0)
29-29: Expected: h3; Actual: h4
Heading levels should only increment by one level at a time
(MD001, heading-increment)
[skip ci] ## [3.25.0](v3.24.1...v3.25.0) (2024-12-16) ### Features * **doc:** cookies 增加 partitioned、removeUnpartitioned 和 priority 选项文档 ([#5376](#5376)) ([60eb8a1](60eb8a1))
[skip ci] ## [4.0.0](v3.24.1...v4.0.0) (2025-01-11) ### ⚠ BREAKING CHANGES * Drop Node.js < 18.19.0 support part of #3644 Breaking changes: - Drop Node.js < 18.19.0 support - Drop generator function support use @eggjs/core@4 eggjs/core#265 ### Features * **doc:** cookies 增加 partitioned、removeUnpartitioned 和 priority 选项文档 ([#5376](#5376)) ([60eb8a1](60eb8a1)) * refactor with typescript to support cjs ane esm both ([#5328](#5328)) ([a09b1cf](a09b1cf))
Checklist
npm test
passesAffected core subsystem(s)
Description of change
Summary by CodeRabbit
New Features
partitioned
,removeUnpartitioned
, andpriority
for enhanced control over cookie behavior.Documentation