-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor with typescript to support cjs ane esm both #5328
Conversation
BREAKING CHANGE: Drop Node.js < 18.19.0 support part of #3644 Breaking changes: - Drop Node.js < 18.19.0 support - Drop generator function support use @eggjs/core@4 eggjs/core#265
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 176 files out of 258 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
跑通第一个单测 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5328 +/- ##
===========================================
- Coverage 99.86% 88.36% -11.51%
===========================================
Files 36 39 +3
Lines 3628 3772 +144
Branches 520 338 -182
===========================================
- Hits 3623 3333 -290
- Misses 5 439 +434 ☔ View full report in Codecov by Sentry. |
[skip ci] ## [4.0.0](v3.24.1...v4.0.0) (2025-01-11) ### ⚠ BREAKING CHANGES * Drop Node.js < 18.19.0 support part of #3644 Breaking changes: - Drop Node.js < 18.19.0 support - Drop generator function support use @eggjs/core@4 eggjs/core#265 ### Features * **doc:** cookies 增加 partitioned、removeUnpartitioned 和 priority 选项文档 ([#5376](#5376)) ([60eb8a1](60eb8a1)) * refactor with typescript to support cjs ane esm both ([#5328](#5328)) ([a09b1cf](a09b1cf))
BREAKING CHANGE: Drop Node.js < 18.19.0 support
part of #3644
Breaking changes:
use @eggjs/core@4 eggjs/core#265