feat: switch httpclient to httpclient2 for retry feature #3626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atian25
force-pushed
the
httpclient2-fix
branch
2 times, most recently
from
0a2344a to
d8ea06f
Compare
atian25
commented
Apr 12, 2019
| @@ -37,12 +37,12 @@ declare module 'egg' { | |||
| // Remove specific property from the specific class | |||
| type RemoveSpecProp<T, P> = Pick<T, Exclude<keyof T, P>>; | |||
|
|
|||
| interface EggHttpClient extends HttpClient2 {} | |||
| interface EggHttpClient extends HttpClient<RequestOptions> {} | |||
There was a problem hiding this comment.
@whxaxes 看看这里。
HttpClient 和 HttpClient2 的 requestThunk 返回值是不一样的。 urllib 里面的 d.ts 感觉有问题。
EggHttpClient 是在 HttpClient2 的基础上，兼容了 HttpClient 的接口，你看看这样定义会不会有问题
atian25
force-pushed
the
httpclient2-fix
branch
4 times, most recently
from
03c19a8 to
31a2777
Compare
Codecov Report
@@ Coverage Diff @@
## master #3626 +/- ##
======================================
Coverage 100% 100%
======================================
Files 34 34
Lines 937 943 +6
======================================
+ Hits 937 943 +6
Continue to review full report at Codecov.
|
atian25
force-pushed
the
httpclient2-fix
branch
from
31a2777 to
d470707
Compare
dead-horse
approved these changes
Apr 16, 2019
popomore
pushed a commit
that referenced
this pull request
Apr 16, 2019
feat: switch httpclient to httpclient2 for retry feature (#3626)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
#3606