feat: switch httpclient to httpclient2 for retry feature #3606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3606 +/- ##
======================================
Coverage 100% 100%
======================================
Files 32 32
Lines 919 919
======================================
Hits 919 919
Continue to review full report at Codecov.
|
atian25
commented
Apr 10, 2019
| await sleep(5000); | ||
| assert(errorHadEmit); |
dead-horse
approved these changes
Apr 11, 2019
popomore
pushed a commit
that referenced
this pull request
Apr 11, 2019
feat: switch httpclient to httpclient2 for retry feature (#3606)
dead-horse
added a commit
that referenced
this pull request
Apr 12, 2019
…)" This reverts commit eead318.
atian25
added a commit
that referenced
this pull request
Apr 12, 2019
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
close #2467