-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
egg-mongoose: no timeout or retry if mongoose failed to connect on start #2403
Comments
legendecas
changed the title
egg-mongoose: egg workers did not start if mongoose failed to connect on start
egg-mongoose: no timeout or retry if mongoose failed to connect on start
Apr 15, 2018
4 tasks
mongodb://127.0.0.1:27017/databaseName |
@zhangming0305 it can be assured it's not an issue related to the mongodb url |
@legendecas i suggest you to create minimal runnable github project that we can reproduce the same error. |
legendecas
added a commit
to legendecas/egg-mongoose-reproduce
that referenced
this issue
Apr 19, 2018
@zhangming0305 Hi, check out this repo https://github.com/legendecas/egg-mongoose-reproduce |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
while using default config like
and run
egg-scripts start
without a valid mongodb running on locallost, egg would not run web workers since egg-mongoose did not connect to mongodb instance yet. And there is no timeout for egg-mongoose's start connect,egg-scripts
will not exit with non-zero code yet web workers did not run, and egg stuck.Now if we start the mongodb instance, egg will not recover to start web workers.
Referring to issue No retries are made after "failed to connect on first connect", errors on first connection shall be re-thrown so that egg will exit with the error in time.
The text was updated successfully, but these errors were encountered: