fix: shall re-throw errors on first connect #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 5 5
Lines 44 44
=====================================
Hits 44 44
Continue to review full report at Codecov.
|
|
You can add |
|
@popomore Updated! 😄 |
|
it's await-first，and you should add testcase for error case. |
|
@popomore Hi! Tests are included 😀 |
popomore
approved these changes
Apr 28, 2018
fengmk2
pushed a commit
that referenced
this pull request
Aug 12, 2023
[skip ci] ## 1.0.0 (2023-08-12) ### ⚠ BREAKING CHANGES * Drop Node.js < 14 and egg < 3 support ### Features * [BREAKING_CHANGE] add unregular model judgement ([#7](#7)) ([ffde348](ffde348)) * bump mongoose version to 5.0 ([#20](#20)) ([a3405d6](a3405d6)) * first implement ([#2](#2)) ([45419ad](45419ad)) * support mongoose global plugin ([#35](#35)) ([1f450fb](1f450fb)) * support multi client ([#15](#15)) ([22d134b](22d134b)) * support plugins for special clients ([#41](#41)) ([67f8f1f](67f8f1f)) * update mongoose's version to be compatable with typescript schemas (Nodejs >=14.x), with Egg>=3.x ([#54](#54)) ([c87f19d](c87f19d)) ### Bug Fixes * doc typo. ([#40](#40)) ([8ef2ebc](8ef2ebc)) * fix __mongoose refer ([#16](#16)) ([b281b15](b281b15)) * hide password of mongo url ([#32](#32)) ([441b6fc](441b6fc)) * remove heartbeat ([#4](#4)) ([343cc78](343cc78)) * replace auth with string replace ([#34](#34)) ([5b9f8ba](5b9f8ba)) * shall re-throw errors on first connect ([#18](#18)) ([dde9037](dde9037)) * **typescript:** types of mongoose should be dependencies ([#24](#24)) ([de7e54e](de7e54e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change
Referring to issue No retries are made after "failed to connect on first connect", errors on first connection shall be re-thrown so that egg will exit with the error in time.
Expect resolving #2403