-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added extkingpin module #10
Conversation
Can you run |
Sure! I did run it before raising PR but I think I set wrong go version(1.16). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid, proposed one idea, otherwise LGTM!
README.md
Outdated
@@ -207,3 +205,25 @@ or via [bingo](https://github.com/bwplotka/bingo) if want to pin it: | |||
go install github.com/bwplotka/bingo | |||
bingo get -u github.com/efficientgo/tools/copyright | |||
``` | |||
|
|||
### Module `github.com/efficientgo/tools/extflag` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Module `github.com/efficientgo/tools/extflag` | |
### Module `github.com/efficientgo/tools/extkingpin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!
README.md
Outdated
|
||
This module provides the PathOrContent flag type which defines two flags to fetch bytes. Either from file (\*-file flag) or content (\* flag). Also returns the content of a YAML file with substituted environment variables. | ||
|
||
```go mdox-gen-exec="sh -c 'tail -n +6 extflag/doc.go'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪🏽 How great is that! (:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😃
Signed-off-by: Saswata Mukherjee <[email protected]>
1d2ce39
to
10b0347
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM 💪🏽
This PR adds in the
extkingpin
module which provides thePathOrContent
flag with environment variable substitution.