Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extkingpin module #10

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Conversation

saswatamcode
Copy link
Collaborator

@saswatamcode saswatamcode commented Jun 9, 2021

This PR adds in the extkingpin module which provides the PathOrContent flag with environment variable substitution.

@bwplotka
Copy link
Contributor

bwplotka commented Jun 9, 2021

Can you run go mod tidy (see lint)?

@saswatamcode
Copy link
Collaborator Author

Sure! I did run it before raising PR but I think I set wrong go version(1.16).

Copy link
Contributor

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid, proposed one idea, otherwise LGTM!

README.md Outdated
@@ -207,3 +205,25 @@ or via [bingo](https://github.com/bwplotka/bingo) if want to pin it:
go install github.com/bwplotka/bingo
bingo get -u github.com/efficientgo/tools/copyright
```

### Module `github.com/efficientgo/tools/extflag`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Module `github.com/efficientgo/tools/extflag`
### Module `github.com/efficientgo/tools/extkingpin

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

README.md Outdated

This module provides the PathOrContent flag type which defines two flags to fetch bytes. Either from file (\*-file flag) or content (\* flag). Also returns the content of a YAML file with substituted environment variables.

```go mdox-gen-exec="sh -c 'tail -n +6 extflag/doc.go'"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏽 How great is that! (:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😃

Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode saswatamcode changed the title Added extflag module Added extkingpin module Jun 9, 2021
Copy link
Contributor

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 💪🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants