Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use efficientgo/tools/extkingpin #39

Merged
merged 1 commit into from
Jun 10, 2021
Merged

Use efficientgo/tools/extkingpin #39

merged 1 commit into from
Jun 10, 2021

Conversation

saswatamcode
Copy link
Collaborator

This PR removes pkg/extflag and replaces it with efficientgo/tools/extkingpin as it was added here. Also updates package version of efficientgo/tools/core which brings about API changes.

@saswatamcode
Use efficientgo/tools/extkingpin
c6f4965 
Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode saswatamcode requested a review from bwplotka June 10, 2021 03:33
@saswatamcode saswatamcode self-assigned this Jun 10, 2021
bwplotka
bwplotka approved these changes Jun 10, 2021
View reviewed changes
Copy link
Owner

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks 👍

@bwplotka bwplotka merged commit df511fd into bwplotka:main Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

Assignees

@saswatamcode saswatamcode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saswatamcode @bwplotka