This repository has been archived by the owner on Aug 31, 2023. It is now read-only.
Function references merge #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SIMD is [phase 5](WebAssembly/simd#507), merge all the changes back into main spec.
Inspired by this downstream test in wabt: WebAssembly/wabt#1775 Fixes: WebAssembly#1404
Whether tail calls across module boundaries would guarantee tail call behavior was previously an open question, but @thibaudmichaud confirmed that they would guarantee tail call behavior in V8 in WebAssembly/tail-call#15 (comment).
Wow, this was painful... All the vector stuff.
Describe correct tail call behavior across modules
Merge upstream
Signed-off-by: Adrian Cole <[email protected]> Co-authored-by: Andreas Rossberg <[email protected]>
This will return early right after generating JS from the wast test files. It will not attempt to run the tests, or do the round trip conversion from wasm <-> wast. This is convenient for proposals to add tests without having to update the reference interpreter with implementation, and generate those tests to JS to run in other Wasm engines. Fixes WebAssembly#1430.
…ind_test Remove use of let from func.bind test
The section name has changed to the tag section a few years ago. This adds the corresponding changes added in WebAssembly/exception-handling#252 and WebAssembly/exception-handling#256.
State principal types
Separate subsumption from instr sequencing; principal typing
|
It seems the regression is related to imports of tags which carry payloads. The following program triggers the bug: (module
(tag $yield (export "yield"))
(tag $spawn (export "spawn") (param i32))
)
(register "test")
(module
(tag $spawn (import "test" "spawn") (param i32))
(tag $yield (import "test" "yield")) ;; commenting this out makes the program validate.
(elem declare func $main $thread1)
(func $main
(suspend $spawn (i32.const 0))
)
(func $thread1)
) |
|
Thanks for grinding through this! |
This commit fixes the errors introduced by the merge of function-references/main into this tree.
dhil
force-pushed
the
wasmfx-funcref-merge
branch
from
d644758
to
f4a1f12
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges
masterwith the latest changes offunction-references/main.