Rename StoreTrunc to StoreWrap for consistency #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewagner
force-pushed
the
trunc-to-wrap
branch
from
74c0752
to
3242cbd
Compare
|
Merging since this seems pretty uncontroversial. |
lukewagner
added a commit
that referenced
this pull request
Oct 1, 2015
Rename StoreTrunc to StoreWrap for consistency
eqrion
pushed a commit
to eqrion/wasm-spec
that referenced
this pull request
Jul 18, 2019
This is copied and modified from this closed PR: WebAssembly/bulk-memory-operations#19
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Mar 2, 2023
…ebAssembly#91) To work on the `exception-handling` formal spec, this repository should be up to date with the required `reference-types` spec.
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Mar 2, 2023
…aster' (WebAssembly#91)" (WebAssembly#117) This reverts commit 0d8fab6. This reverts WebAssembly#91, which squashed all upstream commits into one, which was not the recommended way in https://github.com/WebAssembly/proposals/blob/master/howto.md#syncing-with-upstream-changes.
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Mar 2, 2023
State principal types
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Oct 3, 2023
rossberg
pushed a commit
that referenced
this pull request
Nov 6, 2024
* Update JS API tests for memory64 and table64 * Add memory and table matching tests * Improve loop in assert_Table * Update spec tests to "address" * Rename params in table assertion func
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sunfishcode pointed out that we consistently use "wrap" instead of "truncate" to describe larger-to-smaller integer conversions, so this PR renames
StoreTrunctoStoreWrapwhich is nicer anyway since it's shorter and replaces an abbreviation with a real word. Also tidies up README.md.