Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contribute to dotnet/efcore #119

Closed
9 tasks done
bricelam opened this issue Jan 31, 2023 · 8 comments · Fixed by dotnet/efcore#30291
Closed
9 tasks done

Contribute to dotnet/efcore #119

bricelam opened this issue Jan 31, 2023 · 8 comments · Fixed by dotnet/efcore#30291
Assignees
@bricelam
Labels
fixed
Milestone
8.0.0

Comments

@bricelam
Copy link
Member

bricelam commented Jan 31, 2023 •
edited
Loading

Now that an official version of Microsoft.SqlServer.Types is available, the EF Core team is willing to accept this code into the main EF Core repository. To do that, we'll need everyone that contributed to sign the .NET Foundation CLA.

Can I get acknowledgement from everyone that they are willing to (or already did) sign the CLA? After that, I'll prepare the PR.

Note, the code will continue to be licensed under the MIT--no changes there.

And thanks again for everyone's help getting us to this point!
@cutig3r
Copy link

cutig3r commented Jan 31, 2023

Signed!

@vyrotek
Copy link

vyrotek commented Jan 31, 2023

Done. Excited for this!

@mehdihaghshenas
Copy link

Thank you
I was very appreciate to hear this news

@aljones
Copy link
Collaborator

aljones commented Feb 6, 2023

Signed!

@bricelam bricelam self-assigned this Feb 6, 2023
@kmataru
Copy link

kmataru commented Feb 7, 2023

🤘 Signed

@huan086
Copy link
Collaborator

huan086 commented Feb 7, 2023

Everyone has signed! Exciting!

@kmataru
Copy link

kmataru commented Feb 13, 2023

@bricelam
Maybe try reaching out to @yurijhol (Yury Jhol) on LinkedIn, if he hasn't signed this yet.

bricelam added a commit to bricelam/efcore that referenced this issue Feb 14, 2023
@bricelam
Integrate hierarchyid into the EF Core codebase
0adf618 
Fixes efcore/EFCore.SqlServer.HierarchyId#113, efcore/EFCore.SqlServer.HierarchyId#119, dotnet#365
bricelam added a commit to bricelam/efcore that referenced this issue Feb 14, 2023
@bricelam
Integrate hierarchyid into the EF Core codebase
42b519a 
Resolves efcore/EFCore.SqlServer.HierarchyId#113, resolves efcore/EFCore.SqlServer.HierarchyId#119, resolves dotnet#365
This was referenced Feb 14, 2023
Merged
Closed
@bricelam bricelam added this to the 8.0.0 milestone Feb 14, 2023
@bricelam
Copy link
Member Author

Yeah, I've tried on a few different channels. But it looks like his contribution was small enough (a one-liner) to not require a CLA.

Things are moving forward nicely in PR dotnet/efcore#30291

@bricelam bricelam added the fixed label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
fixed
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

SqlServer: Support hierarchyid bricelam/efcore
7 participants
@vyrotek @bricelam @huan086 @aljones @kmataru @cutig3r @mehdihaghshenas