Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlServer: Support hierarchyid #30291

Merged
merged 2 commits into from
Feb 17, 2023
Merged

SqlServer: Support hierarchyid #30291

merged 2 commits into from
Feb 17, 2023

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam commented Feb 14, 2023

This code was created and previously maintained as a community project. Thank you, amazing EF Core community! Now that an official, cross-platform version of Microsoft.SqlServer.Types is available, we intend to support and maintain it as part of the main EF Core project.

Notice, due to our current stance on the in-memory provider, the EntityFrameworkCore.InMemory.HierarchyId package will not be brought forward. If there's enough interest, it may continue as a community project. (Let us know in efcore/EFCore.SqlServer.HierarchyId#120.)

TODO

  • Use Microsoft.SqlServer.Types
  • Integrate with EF Core codebase
    • Annotate for NRTs
    • Code cleanup
    • Convert internal to pubternal
    • Move tests to existing assemblies (can wait for MQ)
  • Review nupkg descriptions

Resolves efcore/EFCore.SqlServer.HierarchyId#113, resolves efcore/EFCore.SqlServer.HierarchyId#119, resolves #365

@bricelam bricelam requested a review from a team February 14, 2023 22:03
@bricelam bricelam marked this pull request as ready for review February 16, 2023 22:36
@bricelam bricelam merged commit a00a518 into dotnet:main Feb 17, 2023
@bricelam bricelam deleted the hid branch February 17, 2023 17:43
@bricelam
Copy link
Contributor Author

Dang it! I just realized the merge commit (7caf9c4) somehow got messed up (6bf7de7) when I rebased this PR to merge it, so all my intentions of preserving the hierarchyid commit history didn't pan out. But at least it was all there for the CLA check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contribute to dotnet/efcore Use Microsoft.SqlServer.Types SQL Server: Support hierarchyid
2 participants