OpenROAD Unit Tests #244
Merged
OpenROAD Unit Tests #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add openroad.ioplacement unit tests warn when skipping openroad.ioplacement
add openroad patch for -no_merge_via_res
set FP_PDN_CFG inside python step not in the tcl script
donn
reviewed
Nov 14, 2023
donn
reviewed
Nov 14, 2023
donn
reviewed
Nov 14, 2023
donn
reviewed
Nov 14, 2023
openlane/steps/step.py
Outdated
| @@ -721,7 +722,7 @@ def filename_with_counter(): | |||
| dumpable_config = copy_recursive(self.config, translator=visitor) | |||
| dumpable_config["meta"] = { | |||
| "openlane_version": __version__, | |||
| "step": self.__class__.id, | |||
| "step": self.__class__.id.rstrip("-0123456789"), | |||
There was a problem hiding this comment.
If we merge #255 we could just use _original_id
There was a problem hiding this comment.
_original_id is only returned by method with_id. How should I utilize that here ?
There was a problem hiding this comment.
i guess in __init_subclass__ we can check if the class hasattr _original_id and if not, we just set it to the id?
There was a problem hiding this comment.
The problem is self.__class__.id varies when in a flow there a step is repeated. I am not sure where this happens but perhaps at that point _original_id could be set to id without numbers
donn
reviewed
Nov 14, 2023
remove openroad patch do not use hardcode paths in os.path.join
donn
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenROAD.CheckAntennasOpenROAD.DetailedPlacementOpenROAD.DetailedRoutingOpenROAD.FillInsertionOpenROAD.FloorplanOpenROAD.GeneratePDNOpenROAD.GlobalPlacementOpenROAD.IOPlacementOpenROAD.RCXOpenROAD.TapDecapInsertionOpenROAD.IOPlacementwhen a custom io config is set.FP_PDN_CFGinside the python interface not inside OpenROAD tcl script--keep-tmpfor step tests to preserve the test tmp directory.Depends on:
efabless/openlane2-step-unit-tests#7