Cherry picked the fix for the bad packaging back to the main branch #602
Conversation
* Fix an issue where the sonotype plugin does not upload artifacts if the last one is marked as 'don't upload' * rm mystery logback file - not related to the project * Fix warnings about duplicate MANIFEST.MF files in the shaded andhow jar
|
This is related to Issue #592. The initial fix was applied to 'homepage', i.e., it was on the current release. This MR applies that to the main development branch. |
Codecov Report
@@ Coverage Diff @@
## main #602 +/- ##
=========================================
Coverage 84.86% 84.86%
Complexity 18 18
=========================================
Files 133 133
Lines 3667 3667
Branches 447 447
=========================================
Hits 3112 3112
Misses 408 408
Partials 147 147 Continue to review full report at Codecov.
|
| </plugins> | ||
| </build> | ||
| </profile> | ||
| </profiles> |
There was a problem hiding this comment.
I basically moved this profile section from the parent pom, where it applied to all modules, to just this pom. The annotation processor has special requirements for compilation:
- It needs
tools.jar(JDK8) or--add-modules=jdk.compiler(JDK9+) to compile. - It also needs to turn off annotation processing with the
proc:nonecompile flag, so that the compiler doesn't attempt to have the annotation processor its compiling process the annotations in the code its compiling.
The tools.jar dependency of JDK8 caused issues b/c w/ the prior setup (declared in the parent pom), the andhow module inherited the dependency. Thus, it ended up as a dependency in the main distributed artifact's pom file, forcing projects using andhow to provide it. Tools.jar is not available via Maven repos, so this caused other projects to fail unless they were on linux w/ JDK 8.
| </root> | ||
|
|
||
| <logger name="gov.usgs.wma.gcmrc" level="INFO" /> | ||
| </configuration> |
There was a problem hiding this comment.
This is a random file - It shouldn't have been in the project. I'm sure I put it in there accidentally - It looks like a file from work.
| @@ -351,6 +351,7 @@ | |||
| <configuration> | |||
| <serverId>ossrh</serverId> | |||
| <nexusUrl>https://oss.sonatype.org/</nexusUrl> | |||
| <skipLocalStaging>true</skipLocalStaging> | |||
There was a problem hiding this comment.
This was a new issue - It turns out that if the last module is skipped for nexus deploy and nexus is in 'defer' mode (it waits to see if the entire build was successful before uploading artifacts), nexus forgets to go back and do the rest of the uploads.
Its a bug, but apparently they don't plan to fix it:
https://issues.sonatype.org/browse/NEXUS-9138
(Thats me complaining in the last comment on that ticket)
All Submissions:
Have you checked that...