Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging error results in dependency on tools.jar in 1.4.1 Release #592

Closed
eeverman opened this issue Sep 13, 2021 · 1 comment
Closed

Comments

@eeverman
Copy link
Owner

eeverman commented Sep 13, 2021

Describe the bug
Applications trying to use the 1.4.1 release are likely to get a dependency error due to a packaging error that resulted in the pom.xml file including a dependency like this:

    <dependency>
      <groupId>com.sun</groupId>
      <artifactId>tools</artifactId>
      <version>1.8</version>
      <scope>system</scope>
   <systemPath>/Library/Java/JavaVirtualMachines/jdk1.8.0_152.jdk/Contents/Home/jre/../lib/tools.jar</systemPath>
    </dependency>

This dependency is not actually required for AndHow to run and was due to an unexpected maven profile being active. A 1.4.1.1 release will address this shortly.

Environment (please complete the following information):

  • OS: All Windows Systems
  • Java / JDK version: Any system that doesn't have jdk1.8.0_152 installed
  • AndHow Version: 0.4.1

The Fix
Some modifications to how the maven-shade-plugin was used fixed the issue.

@eeverman
Copy link
Owner Author

Fixed by #594
New release 0.4.1.1 created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant