-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: drop support for python 3.10 and django 3.2 #58
base: master
Are you sure you want to change the base?
Conversation
Note for reviewers:The integration test failures are not related with the changes in this PR. These errors will get fix in a different PR, similar to what was done for the rest of the plugins eduNEXT/eox-core#288 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the changes in this PR. I would merge it until the workflow errors are corrected in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. ✨
Limiting juniper and koa may be a good idea, but it is not a blocker because lilac is already limited.
@MaferMazu should we limit Juniper and Koa with the same version as the limit in lilac v2.0.0? |
Yes, because after reviewing the versions, we have v1.0.0, and the following release is v2.0.0. |
46349f9
fb9c77a
to
46349f9
Compare
46349f9
to
450a399
Compare
450a399
to
a984c24
Compare
Description:
This PR removes support for Django 3.2 and Python 3.10 from our plugin.
Rationale:
We have decided to drop support for these versions because none of the Open edX releases we support use Django 3.2 or Python 3.10. Therefore, maintaining compatibility with them is unnecessary.
For more context and information, please refer to AP-1490.
Changes:
tox.ini
file to eliminate specifications for Python 3.10 and Django 3.2.django32.txt
file.How to Test: