Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop support for python 3.10 and django 3.2 #58

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

magajh
Copy link
Contributor

@magajh magajh commented Oct 22, 2024

Description:

This PR removes support for Django 3.2 and Python 3.10 from our plugin.

Rationale:

We have decided to drop support for these versions because none of the Open edX releases we support use Django 3.2 or Python 3.10. Therefore, maintaining compatibility with them is unnecessary.

For more context and information, please refer to AP-1490.

Changes:

  • Updated the test workflow to remove Python 3.10 and Django 3.2 from the Python and Django matrix.
  • Updated the tox.ini file to eliminate specifications for Python 3.10 and Django 3.2.
  • Deleted the django32.txt file.
  • Removed constraints that were only necessary for compatibility with Python 3.10 or Django 3.2.
  • Upgraded the requirements using Python 3.8, which is the oldest version we now support.

How to Test:

  • Ensure that all tests in the GitHub CI pipeline pass successfully.
  • Verify that the pipeline no longer runs tests with Python 3.10 and Django 3.2.

@magajh magajh requested a review from a team as a code owner October 22, 2024 19:04
@magajh
Copy link
Contributor Author

magajh commented Oct 22, 2024

Note for reviewers:

The integration test failures are not related with the changes in this PR. These errors will get fix in a different PR, similar to what was done for the rest of the plugins eduNEXT/eox-core#288

BryanttV
BryanttV previously approved these changes Oct 22, 2024
Copy link
Contributor

@BryanttV BryanttV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the changes in this PR. I would merge it until the workflow errors are corrected in another PR.

mariajgrimaldi
mariajgrimaldi previously approved these changes Oct 22, 2024
MaferMazu
MaferMazu previously approved these changes Oct 22, 2024
Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. ✨

Limiting juniper and koa may be a good idea, but it is not a blocker because lilac is already limited.

@magajh
Copy link
Contributor Author

magajh commented Oct 23, 2024

Looks good. ✨

Limiting juniper and koa may be a good idea, but it is not a blocker because lilac is already limited.

@MaferMazu should we limit Juniper and Koa with the same version as the limit in lilac v2.0.0?

@MaferMazu
Copy link
Contributor

Yes, because after reviewing the versions, we have v1.0.0, and the following release is v2.0.0.
But you only need to add it in Koa because Juniper already has an upper limit.

@magajh magajh force-pushed the mjh/drop-support-python3.10-django3.2 branch from fb9c77a to 46349f9 Compare October 23, 2024 21:29
@magajh magajh changed the base branch from master to mjh/update-integration-tests-workflow October 23, 2024 21:32
@magajh magajh changed the base branch from mjh/update-integration-tests-workflow to master October 28, 2024 22:44
@magajh magajh changed the base branch from master to mjh/update-integration-tests-workflow October 28, 2024 22:47
@magajh magajh force-pushed the mjh/drop-support-python3.10-django3.2 branch from 46349f9 to 450a399 Compare October 28, 2024 22:49
@magajh magajh changed the base branch from mjh/update-integration-tests-workflow to master October 28, 2024 22:49
@magajh magajh force-pushed the mjh/drop-support-python3.10-django3.2 branch from 450a399 to a984c24 Compare October 28, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants