Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ci): update workflow for integration tests #288

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

magajh
Copy link
Contributor

@magajh magajh commented Oct 3, 2024

Description

This PR includes the following updates:

  1. Updated Action Branch: Changed the branch of the action that executes the integration tests to use the main branch with the latest changes. This update allows the tests to run outside the LMS container:

    • uses: eduNEXT/integration-test-in-tutor@main
  2. Removed Unnecessary Input: Removed the openedx_imports_test_function_name input, as it is no longer required with the latest changes:

    • openedx_imports_test_function_name: 'test_current_settings_code_imports'

These changes ensure the workflow is aligned with the latest improvements and simplifies the testing process.

Testing instructions

  • Check the integration tests in the PR checks are executed successfully for tutor versions: 17.0.0, 18.0.0, and nightly

@magajh magajh requested a review from a team as a code owner October 3, 2024 15:39
@magajh magajh changed the title refactor(ci): update workflow for integration tests to use latest act… refactor(ci): update workflow for integration tests Oct 3, 2024
mariajgrimaldi
mariajgrimaldi previously approved these changes Oct 3, 2024
Copy link
Contributor

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups! I was tagged as reviewer but I don't think this was ready for review.

@mariajgrimaldi mariajgrimaldi dismissed their stale review October 3, 2024 18:14

I approved it when it wasn't ready for review

@magajh
Copy link
Contributor Author

magajh commented Oct 3, 2024

@mariajgrimaldi this is ready for review now :D

Copy link
Contributor

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@BryanttV BryanttV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magajh, LGTM

@magajh magajh force-pushed the mjh/adjust-workflow-for-integration-tests branch from 9e2d37e to 683cbc6 Compare October 16, 2024 18:14
@magajh magajh merged commit 9fd92c3 into master Oct 16, 2024
11 checks passed
luisfelipec95 pushed a commit that referenced this pull request Oct 22, 2024
* refactor(ci): update workflow for integration tests to use latest action version

* fix: remove trailing empty line

* fix(ci): use main branch from integration tests action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants