Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace request with node-fetch #1142

Merged
merged 9 commits into from
Aug 11, 2020
Merged

replace request with node-fetch #1142

merged 9 commits into from
Aug 11, 2020

Conversation

panaC
Copy link
Member

@panaC panaC commented Aug 8, 2020

No description provided.

@panaC panaC requested a review from danielweck August 8, 2020 18:39
@panaC panaC self-assigned this Aug 8, 2020
@danielweck
Copy link
Member

This PR partially fixes #970
(there are other uses of request in the codebase, including R2 packages)

@panaC panaC changed the base branch from develop to panac/http_request August 11, 2020 18:05
@panaC panaC merged commit 78f2266 into edrlab:panac/http_request Aug 11, 2020
@danielweck
Copy link
Member

PR superseded by #1145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielweck danielweck Awaiting requested review from danielweck

Assignees

@panaC panaC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panaC @danielweck