[DEV] 'request' NPM package is deprecated

[danielweck]

request/request#3142

[danielweck]

See: https://github.com/googleapis/teeny-request

[danielweck]

request/request#3143

[danielweck]

notes about Electron ‘net’ module support

sindresorhus/got#899

arantes555/electron-fetch#17

[danielweck]

Given our minimal usage of request (and request-promise) in readium-desktop and the underlying R2 packages (i.e. HTTP GET POST PUT with follow-redirects, stream support, JSON body, timeout ... and not much else, no complex middleware and proxy-ing capabilities), I think any of the popular alternative libs would do. However, I am particularly impressed by the documentation of ‘got’, notably the migration guide:
https://github.com/sindresorhus/got/blob/master/documentation/migration-guides.md
...’got’ is also feature-packed if we need to dig deeper, in the future.
Note: this is a non-isomorphic, Node-only lib (which is fine in our integration context), and note that the Electron ‘net’ support is not reliable (which is also okay, see comment above for details).

[panaC]

Sounds good !

[danielweck]

I am re-opening this issue, as the request package dependency is still present in Thorium:

thorium-reader/src/main/services/opds.ts

Line 23 in bee2de1

import * as request from "request";

thorium-reader/package.json

Line 264 in bee2de1

"request": "^2.88.2",

thorium-reader/package.json

Line 297 in bee2de1

"@types/request": "^2.48.5",

=>

thorium-reader/src/main/services/opds.ts

Lines 417 to 432 in bee2de1

	request.post({
	form: login && password ? {
	grant_type: "password",
	username: login,
	password,
	} : {
	grant_type: "refresh_token",
	refresh_token: refreshToken,
	},
	headers,
	agentOptions: {
	rejectUnauthorized: IS_DEV ? false : true,
	},
	method: "POST",
	uri: oAuthUrl,
	})

[danielweck]

Note that request will remain a transitive dependency in Thorium for as long as R2 packages continue to use it (LCP/LSD return/renew, for example).