feat: Add new Properties field to Device DTO and Model #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an extendable field into Device DTO and Model: Properties map[string]any This is useful for some devices that requires extra information. For example, a BACnet device may have properties such as DeviceInstance, Firmware, InstanceID, and ObjectName. fixes edgexfoundry#769 Signed-off-by: Jude Hung <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #800 +/- ##
==========================================
- Coverage 64.42% 64.31% -0.12%
==========================================
Files 80 80
Lines 3092 3099 +7
==========================================
+ Hits 1992 1993 +1
- Misses 911 915 +4
- Partials 189 191 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
judehung
added a commit
to judehung/device-sdk-go
that referenced
this pull request
Feb 18, 2023
…Device dto Per edgexfoundry/go-mod-core-contracts#800, the Device DTO is added with a new field "Properties", so the swagger file needs to be updated correspondingly. Moreover, this commit also updates the swagger file to remove those fields that had been taken out of Device DTO before: - created - modified - serviceId - profileId This commit also adds back a newly created field "tags" into the Device DTO. Signed-off-by: Jude Hung <[email protected]>
5 tasks
judehung
added a commit
to judehung/edgex-go
that referenced
this pull request
Feb 20, 2023
…Device DTO Per edgexfoundry/go-mod-core-contracts#800, the Device DTO is added with a new field properties, so the swagger file of core-metadata needs to be updated correspondingly. This commit also updates the swagger with newly created field tags of the Device DTO. Signed-off-by: Jude Hung <[email protected]>
judehung
added a commit
to judehung/edgex-go
that referenced
this pull request
Feb 20, 2023
…Device DTO Per edgexfoundry/go-mod-core-contracts#800, the Device DTO is added with a new field properties, so the swagger file of core-metadata needs to be updated correspondingly. This commit also updates the swagger with newly created field tags of the Device DTO. Signed-off-by: Jude Hung <[email protected]>
judehung
added a commit
to judehung/edgex-docs
that referenced
this pull request
Feb 22, 2023
…isionWatcher dto Per edgexfoundry/go-mod-core-contracts#803 and edgexfoundry/go-mod-core-contracts#800, new fields `properties` are added into Device dto and ProvisionWatcher dto. This PR updates edgex-docs with the description of these new fields. Signed-off-by: Jude Hung <[email protected]>
judehung
added a commit
to judehung/edgex-docs
that referenced
this pull request
Feb 22, 2023
…isionWatcher dto Per edgexfoundry/go-mod-core-contracts#803 and edgexfoundry/go-mod-core-contracts#800, new fields `properties` are added into Device dto and ProvisionWatcher dto. This PR updates edgex-docs with the description of these new fields. fixes edgexfoundry#969 Signed-off-by: Jude Hung <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an extendable field into Device DTO and Model: Properties map[string]any
This is useful for some devices that requires extra information. For example, a BACnet device may have properties such as DeviceInstance, Firmware, InstanceID, and ObjectName.
fixes #769
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)