fix: Update swagger to match latest changes in go-mod-core-contracts Device DTO #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Device dto Per edgexfoundry/go-mod-core-contracts#800, the Device DTO is added with a new field "Properties", so the swagger file needs to be updated correspondingly. Moreover, this commit also updates the swagger file to remove those fields that had been taken out of Device DTO before: - created - modified - serviceId - profileId This commit also adds back a newly created field "tags" into the Device DTO. Signed-off-by: Jude Hung <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1333 +/- ##
=======================================
Coverage 52.69% 52.69%
=======================================
Files 26 26
Lines 2319 2319
=======================================
Hits 1222 1222
Misses 993 993
Partials 104 104 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per edgexfoundry/go-mod-core-contracts#800, the Device DTO is added with a new field
properties, so the swagger file needs to be updated correspondingly.Moreover, this commit also updates the swagger file to remove those fields that had been taken out of Device DTO before:
This commit also adds back a newly created field
tagsinto the Device DTO.If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-sdk-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)