-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove ApiVersion from normal DTOs except EventDTO #538
Conversation
I tried to write a custom tag to verify the DTO which should contain api version like:
But it didn't work because the validation lib ignore the embedded struct's tag. So I check the apiVersion in the Validation function. |
Close edgexfoundry#541 Signed-off-by: weichou <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #538 +/- ##
==========================================
+ Coverage 55.79% 55.87% +0.07%
==========================================
Files 119 119
Lines 3570 3551 -19
==========================================
- Hits 1992 1984 -8
+ Misses 1385 1374 -11
Partials 193 193
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Close #537
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/master/.github/Contributing.md.
What is the current behavior?
The apiVersion is required.
Issue Number: #537
What is the new behavior?
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Are there any specific instructions or things that should be known prior to reviewing?
Other information