-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V2] Set apiVersion to optional in normal DTOs, except for requestDTOs and EventDTO #537
Comments
- Remove the required validation tag from apiVersion. - Check the requestDTOs and EventDTO which should contains valid api version Close edgexfoundry#537 Signed-off-by: weichou <[email protected]>
Now that we have had some time to see how this is working, maybe best to focus on having ApiVersion only on top level DTOs (i.e. Request/Response DTOs) and sub-DTOS that can be received by client w/o a parent Request/Response DTO (i.e. Event DTO). The other DTOs are just composite DTOs, so as we have seen it is redundant to have ApiVersion if the a parent DTO already has it. So my suggestion now is to remove ApiVersion from DTOs that are not one of the following?
@cloudxxx8 , @jpwhitemn Thoughts? |
@lenny-intel I would like to also re-visit the reason we keep ApiVersion in Event. |
@cloudxxx8 , the Event DTO is what is exported to external destinations. Having the ApiVersion on Event is important if that end point has to support existing V1 deployments as the V2 deployments come on-line. |
@lenny-intel I understand now. In this case, we can implement it as your suggestion. |
@lenny-intel I removed the ApiVersion from normal DTOs except event and reading. Could you help review the PR #538? |
Close edgexfoundry#537 Signed-off-by: weichou <[email protected]>
Per working group decision
see https://wiki.edgexfoundry.org/display/FA/Core+Working+Group?preview=/329472/60784641/CoreWG-AgendaAndMinutes-3-3-2021.pdf
The text was updated successfully, but these errors were encountered: