feat(snap): add additional tokens for app-service-configurable profiles

[siggiskulason]

The external-mqtt-trigger and app-push-to-core profiles are used by the TAF integration tests.

This PR enables those profiles by creating tokens for them and making the tokens available for
the edgex-app-service-configurable snap.

Signed-off-by: Siggi Skulason [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

• I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
• I am not introducing a new dependency (add notes below if you are)
• I have added unit tests for the new feature or bug fix (if not, why?) N/A
• I have fully tested (add details below) this the new feature or bug fix (if not, why?)
• I have opened a PR for the related docs change (if not, why?) n/a

Testing Instructions

1. Create a clean build of the snap
2. Install the snap
3. Confirm the token exists: sudo ls /var/snap/edgexfoundry/current/secrets/app-external-mqtt-trigger/secrets-token.json

New Dependency Instructions (If applicable)

[farshidtz]

Can't we add this token for the test via the config arguments?
https://github.com/edgexfoundry/edgex-go/tree/main/snap#secret-store-settings-prefix-envsecurity-secret-store

It also applies to app-functional-tests.

[siggiskulason]

Can't we add this token for the test via the config arguments? https://github.com/edgexfoundry/edgex-go/tree/main/snap#secret-store-settings-prefix-envsecurity-secret-store

It also applies to app-functional-tests.

Yes, indeed, I can do

LIST=`sudo snap get edgexfoundry env.security-secret-store.add-secretstore-tokens`
LIST2=`sudo snap get edgexfoundry env.security-secret-store.add-known-secrets`
sudo snap set edgexfoundry env.security-secret-store.add-secretstore-tokens="$LIST,app-external-mqtt-trigger"
sudo snap set edgexfoundry env.security-secret-store.add-known-secrets="$LIST2,redisdb[app-external-mqtt-trigger]"
sudo snap restart edgexfoundry.security-secretstore-setup 

and that generates the token. However, it adds a few extra steps and the requirement to revoke and regenerate all tokens and since this profile is one of the built-in profiles of app-service-configurable, it might make sense to include a token for it by default.

Also - the config hook in edgexfoundry currently expects all the tokens to be there for the slots listed in the connecting snap. So if we add a slot there for this profile (which PR edgexfoundry/app-service-configurable#361 does), then the content interface doesn't connect unless that token in present. (we get an error like edgex-secretstore-token: could not find token for app-external-mqtt-trigger and the snap doesn't start

[siggiskulason]

I added a 2nd commit to this PR to add the app-push-to-core token as well, so we now have tokens for all 6 built-in profiles.

[siggiskulason]

force-pushed a rebase to main

[farshidtz]

ignore this..

[farshidtz]

Looks good. But please update the PR title:

• multiple tokens are added now
• sounds more like a new feature (feat) than fix

[siggiskulason]

Looks good. But please update the PR title:

• multiple tokens are added now
• sounds more like a new feature (feat) than fix

thanks - done.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
9.2% Duplication

[farshidtz]

Thanks @siggiskulason.

[lenny-goodell]

LGTM