feat(snap): add additional tokens for app-service-configurable profiles #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The external-mqtt-trigger profile is used by the TAF integration tests. This commit updates the snap so that the secret-store token for that profile is copied from the edgexfoundry snap Signed-off-by: Siggi Skulason <[email protected]>
farshidtz
reviewed
Nov 24, 2021
This commit updates the snap so that the token for the push-to-core secret-store profile is copied from the edgexfoundry snap It also changes the list of profiles to a YAML list to shorten the line Signed-off-by: Siggi Skulason <[email protected]>
Merged
5 tasks
farshidtz
approved these changes
Nov 25, 2021
farshidtz
reviewed
Nov 26, 2021
| - $SNAP_DATA/app-external-mqtt-trigger | ||
| - $SNAP_DATA/app-functional-tests | ||
| - $SNAP_DATA/app-push-to-core | ||
| - $SNAP_DATA/app-rules-engine |
There was a problem hiding this comment.
In future, we need to improve the way this content interface works to allow receiving tokens that are requested dynamically from the secret store, e.g. for development, testing, multiple custom names.
siggiskulason
changed the title
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds updates the snap so that the secret-store tokens for
are copied from the edgexfoundry snap. Both are built-in profiles that are referenced in the TAF tests
Signed-off-by: Siggi Skulason [email protected]
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-service-configurable/blob/main/.github/CONTRIBUTING.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
To test:
sudo snap connect edgexfoundry:edgex-secretstore-token edgex-app-service-configurablesudo snap set edgex-app-service-configurable profile=external-mqtt-triggerNew Dependency Instructions (If applicable)