Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snap): Refactor to avoid conflicts with readonly config provider directory #535

Merged
merged 1 commit into from
Mar 18, 2023

Conversation

MonicaisHer
Copy link
Contributor

@MonicaisHer MonicaisHer commented Mar 17, 2023

Changes to incorporate the following fixes:

Also, removing the deprecated startup-duration and startup-interval options.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-mqtt-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Setup:

snap install ./edgex-device-mqtt_3.0.0-dev.14_amd64.snap --dangerous
snap install ./edgex-config-provider/edgex-config-provider-example_2.3_amd64.snap --dangerous
snap install edgexfoundry --edge
sudo snap connect edgexfoundry:edgex-secretstore-token edgex-device-mqtt:edgex-secretstore-token
sudo snap connect edgex-device-mqtt:device-mqtt-config edgex-config-provider-example:device-mqtt-config

Validate that there are config files come from config provider:

$ snap start edgex-device-mqtt && journalctl -f | grep "app=device-mqtt source=message.go"
level=INFO ts=2023-03-17T12:43:26.511670858Z app=device-mqtt source=message.go:55 msg="provided by config provider"

Validate that .env file exists and works:

$ snap set edgex-device-mqtt config.writable-loglevel=DEBUG
$ cat /var/snap/edgex-device-mqtt/current/config/device-mqtt/overrides.env 
# Sys-gen env vars from snap options:
WRITABLE_LOGLEVEL="DEBUG"

$ snap restart edgex-device-mqtt && journalctl -f | grep device-mqtt | grep DEBUG
# ... level=DEBUG ...

New Dependency Instructions (If applicable)

@MonicaisHer MonicaisHer requested a review from farshidtz March 17, 2023 12:52
@codecov-commenter
Copy link

Codecov Report

Merging #535 (1fb1655) into main (4e0b4e1) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage   21.50%   21.50%           
=======================================
  Files           5        5           
  Lines         493      493           
=======================================
  Hits          106      106           
  Misses        373      373           
  Partials       14       14           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants